First of all thank you for this great article there is a lot of valuable advice in there. One question regarding the PR-over-arguing part:
- what if there is this one dev (junior dev) in the team that keeps making opinionated (nitpicky) comments on every (others) review. You on the other hand are the non-strict kind of reviewer. There fore, will not this situation lead the less-strict developer to an unfair position of always having to take in things without her/himself being picky? How would you handle such situations?
It depends. Usually if the other developer making some opinionated comments, you can ask them "What are the value to make such changes?", and further ask if such asks was mentioned in the company's style-guide.
Based on the answer, I will decide whether or not I should make the change based on the comments. If the change is very drastic, where it may involved a an entire re-write, I may pushback, and give justification on why I wrote it in this a certain way. If the change is minuscule, I may just change it to avoiding going back and forth with the reviewer. Again, I think it is based on how you see fit into your current situations.
I made some opinionated comments sometimes, and I usually put in a "nit" in front of my comments to indicate that this is nitpicky.
First of all thank you for this great article there is a lot of valuable advice in there. One question regarding the PR-over-arguing part:
- what if there is this one dev (junior dev) in the team that keeps making opinionated (nitpicky) comments on every (others) review. You on the other hand are the non-strict kind of reviewer. There fore, will not this situation lead the less-strict developer to an unfair position of always having to take in things without her/himself being picky? How would you handle such situations?
Hi @frexos thanks for reading my article!
It depends. Usually if the other developer making some opinionated comments, you can ask them "What are the value to make such changes?", and further ask if such asks was mentioned in the company's style-guide.
Based on the answer, I will decide whether or not I should make the change based on the comments. If the change is very drastic, where it may involved a an entire re-write, I may pushback, and give justification on why I wrote it in this a certain way. If the change is minuscule, I may just change it to avoiding going back and forth with the reviewer. Again, I think it is based on how you see fit into your current situations.
I made some opinionated comments sometimes, and I usually put in a "nit" in front of my comments to indicate that this is nitpicky.
I hope this helps!